Hotfix: refactor of #21221#21293
Merged
nielslyngsoe merged 11 commits intorelease/17.1from Jan 6, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the property type variation change handling (from PR #21221) to improve how property values are migrated when variation settings change during document type editing. The key improvement is performing client-side value migration by observing property type changes rather than reloading the entire document from the server.
Key Changes:
- Implemented client-side value migration when property variation settings change (culture/segment)
- Added
_processIncomingDatacall to entity-detail workspace reload method for consistency - Removed server-side fallback logic from property value preset builder
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| entity-detail-workspace-base.ts | Added _processIncomingData call in reload method to ensure incoming data is processed consistently with the load method |
| property-value-preset-variant-builder.controller.ts | Removed fallback logic for handling variation setting changes, simplifying the preset builder |
| content-detail-workspace-base.ts | Refactored to observe property types and perform client-side value migration when variation settings change, replacing the previous reload-based approach |
...mbraco.Web.UI.Client/src/packages/content/content/workspace/content-detail-workspace-base.ts
Outdated
Show resolved
Hide resolved
...mbraco.Web.UI.Client/src/packages/content/content/workspace/content-detail-workspace-base.ts
Outdated
Show resolved
Hide resolved
...mbraco.Web.UI.Client/src/packages/content/content/workspace/content-detail-workspace-base.ts
Outdated
Show resolved
Hide resolved
...mbraco.Web.UI.Client/src/packages/content/content/workspace/content-detail-workspace-base.ts
Outdated
Show resolved
Hide resolved
...mbraco.Web.UI.Client/src/packages/content/content/workspace/content-detail-workspace-base.ts
Outdated
Show resolved
Hide resolved
The two tests for invariant<->variant migration were testing behavior that has been moved to UmbContentDetailWorkspaceTypeTransformController during refactoring. The preset builder no longer handles variation migration via fallback logic. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Tests verify that property variation changes are properly handled: - Invariant to variant migration (values get default culture) - Variant to invariant migration (values become null culture) - Values are preserved during migration - No changes when variation stays the same - Multiple properties with different variations 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Fixed test mocking to expose contentTypeProperties as an Observable instead of a state object. All tests now pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Extracted helper methods to reduce complexity from 12 to 5: - #getDefaultLanguage(): Gets default language - #transformValueForVariationChange(): Handles value transformation logic Addresses CodeScene warning about cyclomatic complexity threshold. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
iOvergaard
approved these changes
Jan 6, 2026
Contributor
iOvergaard
left a comment
iOvergaard
left a comment
There was a problem hiding this comment.
Great work on the refactoring! 👍
The test updates make sense - the variation migration logic has moved from the preset builder to the workspace-level transform controller, so the tests should live there too.
Changes verified:
✅ Removed 2 obsolete tests from preset builder (they were testing behavior that no longer exists there)
✅ Added 5 comprehensive tests for UmbContentDetailWorkspaceTypeTransformController covering all migration scenarios
✅ All tests passing (preset builder: 6 tests, transform controller: 5 tests)
✅ Addressed CodeScene complexity warning (reduced from 12 to 5 by extracting helper methods)
The new tests properly cover:
- Invariant → variant migration (values get default culture)
- Variant → invariant migration (values become null culture)
- Value preservation during migration
- No-op when variation doesn't change
- Multiple properties with different variations
nielslyngsoe
added a commit
that referenced
this pull request
Jan 7, 2026
This was referenced Jan 12, 2026
Merged
alexsee
pushed a commit
to alexsee/umbraco-container
that referenced
this pull request
Jan 18, 2026
Updated [Umbraco.Cms.Persistence.Sqlite](https://github.com/umbraco/Umbraco-CMS) from 17.0.2 to 17.1.0. <details> <summary>Release notes</summary> _Sourced from [Umbraco.Cms.Persistence.Sqlite's releases](https://github.com/umbraco/Umbraco-CMS/releases)._ ## 17.1.0 # What's Changed Since 17.1.0-rc ### 🐛 Bug Fixes * Media: Fix files not deleted from disk when recycle bin protection is enabled by @AndyButland in umbraco/Umbraco-CMS#21309 * Document Editing: Refactor of Fix property variation change breaking document save via Infinite Editing (closes #21195) by @nielslyngsoe in umbraco/Umbraco-CMS#21293 * umbraco/Umbraco-CMS#21306 by @calm329 in umbraco/Umbraco-CMS#21306 **Full Changelog**: umbraco/Umbraco-CMS@release-17.1.0-rc...release-17.1.0 ## What's Changed Since the Last Release (17.0.2) ### 📦 Dependencies * Dependencies: Fixed dependency conflicts when installing Microsoft.EntityFrameworkCore.Design (closes #20421) by @lauraneto in umbraco/Umbraco-CMS#20474 * Dependencies: Remove `Microsoft.CodeAnalysis.CSharp` dependency from Umbraco.Infrastructure by @lauraneto in umbraco/Umbraco-CMS#20481 * build(deps): bumps @umbraco-ui/uui from 1.16.0-rc.0 to 1.16.0 by @iOvergaard in umbraco/Umbraco-CMS#20535 * Bump vite from 7.1.9 to 7.1.11 in /src/Umbraco.Web.UI.Client by @dependabot[bot] in umbraco/Umbraco-CMS#20580 * Bump vite from 7.1.9 to 7.1.11 in /src/Umbraco.Web.UI.Login by @dependabot[bot] in umbraco/Umbraco-CMS#20621 * Bump playwright and @playwright/test in /tests/Umbraco.Tests.AcceptanceTest by @dependabot[bot] in umbraco/Umbraco-CMS#20579 * Bump the npm_and_yarn group across 2 directories with 1 update by @dependabot[bot] in umbraco/Umbraco-CMS#20863 * Dependencies: Updates some dependencies to latest minor or patch releases by @AndyButland in umbraco/Umbraco-CMS#20953 * build(deps): bumps monaco-editor from 0.54.0 to 0.55.1 by @iOvergaard in umbraco/Umbraco-CMS#21054 ### 🌈 Accessibility Improvements * Entity Actions: Create button discernible text (fixes #20205) by @OskarKruger in umbraco/Umbraco-CMS#20434 * Entity Actions: More create button discernible text, extension of #20434 by @OskarKruger in umbraco/Umbraco-CMS#20458 * Header: Adjusted button focus border color contrast by @MrHutmat in umbraco/Umbraco-CMS#20562 * Login: Added custom validation for missing password and user/email on the login form by @MrHutmat in umbraco/Umbraco-CMS#20233 * Accessibility: Adding a label attribute for `<uui-button>` in news dashboard by @MrHutmat in umbraco/Umbraco-CMS#20780 * Keyboard navigation: Return to opening element after modal close by @MrHutmat in umbraco/Umbraco-CMS#20782 ### 🚀 New Features * Preview: Allows changing the preview environment inside the preview app, and other UX changes that enhance the experience by @leekelleher in umbraco/Umbraco-CMS#20598 * Login: Adds show/hide password toggle by @MrHutmat in umbraco/Umbraco-CMS#20611 * Adds Clear Clipboard button & logic by @warrenbuckley in umbraco/Umbraco-CMS#20757 * Member types: Implement containers by @ronaldbarendse in umbraco/Umbraco-CMS#20706 * Log viewer: Improves search functionality and code quality by @iOvergaard in umbraco/Umbraco-CMS#20913 * Log Viewer: Enhances the donut chart to be responsive, link to log search, and show numbers directly by @iOvergaard in umbraco/Umbraco-CMS#20928 * Culture and Hostnames: Add ability to sort hostnames (closes #20691) by @MrHutmat in umbraco/Umbraco-CMS#20826 * Localization: Adds `termOrDefault()` method to accept a fallback value by @iOvergaard in umbraco/Umbraco-CMS#20947 * Block Grid: Sort mode by @leekelleher in umbraco/Umbraco-CMS#20869 * News Dashboard: Adding functionality to overwrite the cache duration by @NillasKA in umbraco/Umbraco-CMS#21064 * Block List: Sort mode by @leekelleher in umbraco/Umbraco-CMS#21060 * Extend RTE output in Delivery API for better support for multi-site URL resolution by @MiguelGuedelha in umbraco/Umbraco-CMS#20846 * Content Types: Introduce schema service to support future schema generation by @lauraneto in umbraco/Umbraco-CMS#21031 * Delivery API: Adding allow list for content types by @NillasKA in umbraco/Umbraco-CMS#21111 * Emails: Add `Expires` header by @rickbutterfield in umbraco/Umbraco-CMS#20285 * Indexing: Make the indexing batch size configurable by @kjac in umbraco/Umbraco-CMS#20543 * Media: Add protection to restrict access to media in recycle bin (closes #2931) by @AndyButland in umbraco/Umbraco-CMS#20378 * Collection: Introduce Collection Item Card extension type by @madsrasmussen in umbraco/Umbraco-CMS#20954 * Collection: Introduce Collection Item Ref extension type by @madsrasmussen in umbraco/Umbraco-CMS#20994 ... (truncated) ## 17.1.0-rc ## What's Changed ### 📦 Dependencies * Dependencies: Fixed dependency conflicts when installing Microsoft.EntityFrameworkCore.Design (closes #20421) by @lauraneto in umbraco/Umbraco-CMS#20474 * Dependencies: Remove `Microsoft.CodeAnalysis.CSharp` dependency from Umbraco.Infrastructure by @lauraneto in umbraco/Umbraco-CMS#20481 * build(deps): bumps @umbraco-ui/uui from 1.16.0-rc.0 to 1.16.0 by @iOvergaard in umbraco/Umbraco-CMS#20535 * Bump vite from 7.1.9 to 7.1.11 in /src/Umbraco.Web.UI.Client by @dependabot[bot] in umbraco/Umbraco-CMS#20580 * Bump vite from 7.1.9 to 7.1.11 in /src/Umbraco.Web.UI.Login by @dependabot[bot] in umbraco/Umbraco-CMS#20621 * Bump playwright and @playwright/test in /tests/Umbraco.Tests.AcceptanceTest by @dependabot[bot] in umbraco/Umbraco-CMS#20579 * Bump the npm_and_yarn group across 2 directories with 1 update by @dependabot[bot] in umbraco/Umbraco-CMS#20863 * Dependencies: Updates some dependencies to latest minor or patch releases by @AndyButland in umbraco/Umbraco-CMS#20953 * build(deps): bumps monaco-editor from 0.54.0 to 0.55.1 by @iOvergaard in umbraco/Umbraco-CMS#21054 ### 🌈 Accessibility Improvements * Entity Actions: Create button discernible text (fixes #20205) by @OskarKruger in umbraco/Umbraco-CMS#20434 * Entity Actions: More create button discernible text, extension of #20434 by @OskarKruger in umbraco/Umbraco-CMS#20458 * Header: Adjusted button focus border color contrast by @MrHutmat in umbraco/Umbraco-CMS#20562 * Login: Added custom validation for missing password and user/email on the login form by @MrHutmat in umbraco/Umbraco-CMS#20233 * Accessibility: Adding a label attribute for `<uui-button>` in news dashboard by @MrHutmat in umbraco/Umbraco-CMS#20780 * Keyboard navigation: Return to opening element after modal close by @MrHutmat in umbraco/Umbraco-CMS#20782 ### 🚀 New Features * Preview: Allows changing the preview environment inside the preview app, and other UX changes that enhance the experience by @leekelleher in umbraco/Umbraco-CMS#20598 * Login: Adds show/hide password toggle by @MrHutmat in umbraco/Umbraco-CMS#20611 * Adds Clear Clipboard button & logic by @warrenbuckley in umbraco/Umbraco-CMS#20757 * Member types: Implement containers by @ronaldbarendse in umbraco/Umbraco-CMS#20706 * Log viewer: Improves search functionality and code quality by @iOvergaard in umbraco/Umbraco-CMS#20913 * Log Viewer: Enhances the donut chart to be responsive, link to log search, and show numbers directly by @iOvergaard in umbraco/Umbraco-CMS#20928 * Culture and Hostnames: Add ability to sort hostnames (closes #20691) by @MrHutmat in umbraco/Umbraco-CMS#20826 * Localization: Adds `termOrDefault()` method to accept a fallback value by @iOvergaard in umbraco/Umbraco-CMS#20947 * Block Grid: Sort mode by @leekelleher in umbraco/Umbraco-CMS#20869 * News Dashboard: Adding functionality to overwrite the cache duration by @NillasKA in umbraco/Umbraco-CMS#21064 * Block List: Sort mode by @leekelleher in umbraco/Umbraco-CMS#21060 * Extend RTE output in Delivery API for better support for multi-site URL resolution by @MiguelGuedelha in umbraco/Umbraco-CMS#20846 * Content Types: Introduce schema service to support future schema generation by @lauraneto in umbraco/Umbraco-CMS#21031 * Delivery API: Adding allow list for content types by @NillasKA in umbraco/Umbraco-CMS#21111 * Emails: Add `Expires` header by @rickbutterfield in umbraco/Umbraco-CMS#20285 * Indexing: Make the indexing batch size configurable by @kjac in umbraco/Umbraco-CMS#20543 * Media: Add protection to restrict access to media in recycle bin (closes #2931) by @AndyButland in umbraco/Umbraco-CMS#20378 * Collection: Introduce Collection Item Card extension type by @madsrasmussen in umbraco/Umbraco-CMS#20954 * Collection: Introduce Collection Item Ref extension type by @madsrasmussen in umbraco/Umbraco-CMS#20994 * Collection: Introduce Card and Ref Collection View kinds by @madsrasmussen in umbraco/Umbraco-CMS#21037 ### 🚤 Performance * Performance: Optimize memory footprint of document URL cache (closes #21055) by @AndyButland in umbraco/Umbraco-CMS#21066 * Distributed Background Jobs: Improve distributed background job locking behavior and performance by @nikolajlauridsen in umbraco/Umbraco-CMS#21100 * Repositories: Optimize repository caches to populate for both int and GUID keys by @AndyButland in umbraco/Umbraco-CMS#21124 * Performance: Re-introduce lazy locks by @lauraneto in umbraco/Umbraco-CMS#21102 ### 🐛 Bug Fixes ... (truncated) Commits viewable in [compare view](umbraco/Umbraco-CMS@release-17.0.2...release-17.1.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
alexsee
added a commit
to alexsee/umbraco-container
that referenced
this pull request
Jan 18, 2026
Updated [Umbraco.Cms.DevelopmentMode.Backoffice](https://github.com/umbraco/Umbraco-CMS) from 17.0.2 to 17.1.0. <details> <summary>Release notes</summary> _Sourced from [Umbraco.Cms.DevelopmentMode.Backoffice's releases](https://github.com/umbraco/Umbraco-CMS/releases)._ ## 17.1.0 # What's Changed Since 17.1.0-rc ### 🐛 Bug Fixes * Media: Fix files not deleted from disk when recycle bin protection is enabled by @AndyButland in umbraco/Umbraco-CMS#21309 * Document Editing: Refactor of Fix property variation change breaking document save via Infinite Editing (closes #21195) by @nielslyngsoe in umbraco/Umbraco-CMS#21293 * umbraco/Umbraco-CMS#21306 by @calm329 in umbraco/Umbraco-CMS#21306 **Full Changelog**: umbraco/Umbraco-CMS@release-17.1.0-rc...release-17.1.0 ## What's Changed Since the Last Release (17.0.2) ### 📦 Dependencies * Dependencies: Fixed dependency conflicts when installing Microsoft.EntityFrameworkCore.Design (closes #20421) by @lauraneto in umbraco/Umbraco-CMS#20474 * Dependencies: Remove `Microsoft.CodeAnalysis.CSharp` dependency from Umbraco.Infrastructure by @lauraneto in umbraco/Umbraco-CMS#20481 * build(deps): bumps @umbraco-ui/uui from 1.16.0-rc.0 to 1.16.0 by @iOvergaard in umbraco/Umbraco-CMS#20535 * Bump vite from 7.1.9 to 7.1.11 in /src/Umbraco.Web.UI.Client by @dependabot[bot] in umbraco/Umbraco-CMS#20580 * Bump vite from 7.1.9 to 7.1.11 in /src/Umbraco.Web.UI.Login by @dependabot[bot] in umbraco/Umbraco-CMS#20621 * Bump playwright and @playwright/test in /tests/Umbraco.Tests.AcceptanceTest by @dependabot[bot] in umbraco/Umbraco-CMS#20579 * Bump the npm_and_yarn group across 2 directories with 1 update by @dependabot[bot] in umbraco/Umbraco-CMS#20863 * Dependencies: Updates some dependencies to latest minor or patch releases by @AndyButland in umbraco/Umbraco-CMS#20953 * build(deps): bumps monaco-editor from 0.54.0 to 0.55.1 by @iOvergaard in umbraco/Umbraco-CMS#21054 ### 🌈 Accessibility Improvements * Entity Actions: Create button discernible text (fixes #20205) by @OskarKruger in umbraco/Umbraco-CMS#20434 * Entity Actions: More create button discernible text, extension of #20434 by @OskarKruger in umbraco/Umbraco-CMS#20458 * Header: Adjusted button focus border color contrast by @MrHutmat in umbraco/Umbraco-CMS#20562 * Login: Added custom validation for missing password and user/email on the login form by @MrHutmat in umbraco/Umbraco-CMS#20233 * Accessibility: Adding a label attribute for `<uui-button>` in news dashboard by @MrHutmat in umbraco/Umbraco-CMS#20780 * Keyboard navigation: Return to opening element after modal close by @MrHutmat in umbraco/Umbraco-CMS#20782 ### 🚀 New Features * Preview: Allows changing the preview environment inside the preview app, and other UX changes that enhance the experience by @leekelleher in umbraco/Umbraco-CMS#20598 * Login: Adds show/hide password toggle by @MrHutmat in umbraco/Umbraco-CMS#20611 * Adds Clear Clipboard button & logic by @warrenbuckley in umbraco/Umbraco-CMS#20757 * Member types: Implement containers by @ronaldbarendse in umbraco/Umbraco-CMS#20706 * Log viewer: Improves search functionality and code quality by @iOvergaard in umbraco/Umbraco-CMS#20913 * Log Viewer: Enhances the donut chart to be responsive, link to log search, and show numbers directly by @iOvergaard in umbraco/Umbraco-CMS#20928 * Culture and Hostnames: Add ability to sort hostnames (closes #20691) by @MrHutmat in umbraco/Umbraco-CMS#20826 * Localization: Adds `termOrDefault()` method to accept a fallback value by @iOvergaard in umbraco/Umbraco-CMS#20947 * Block Grid: Sort mode by @leekelleher in umbraco/Umbraco-CMS#20869 * News Dashboard: Adding functionality to overwrite the cache duration by @NillasKA in umbraco/Umbraco-CMS#21064 * Block List: Sort mode by @leekelleher in umbraco/Umbraco-CMS#21060 * Extend RTE output in Delivery API for better support for multi-site URL resolution by @MiguelGuedelha in umbraco/Umbraco-CMS#20846 * Content Types: Introduce schema service to support future schema generation by @lauraneto in umbraco/Umbraco-CMS#21031 * Delivery API: Adding allow list for content types by @NillasKA in umbraco/Umbraco-CMS#21111 * Emails: Add `Expires` header by @rickbutterfield in umbraco/Umbraco-CMS#20285 * Indexing: Make the indexing batch size configurable by @kjac in umbraco/Umbraco-CMS#20543 * Media: Add protection to restrict access to media in recycle bin (closes #2931) by @AndyButland in umbraco/Umbraco-CMS#20378 * Collection: Introduce Collection Item Card extension type by @madsrasmussen in umbraco/Umbraco-CMS#20954 * Collection: Introduce Collection Item Ref extension type by @madsrasmussen in umbraco/Umbraco-CMS#20994 ... (truncated) ## 17.1.0-rc ## What's Changed ### 📦 Dependencies * Dependencies: Fixed dependency conflicts when installing Microsoft.EntityFrameworkCore.Design (closes #20421) by @lauraneto in umbraco/Umbraco-CMS#20474 * Dependencies: Remove `Microsoft.CodeAnalysis.CSharp` dependency from Umbraco.Infrastructure by @lauraneto in umbraco/Umbraco-CMS#20481 * build(deps): bumps @umbraco-ui/uui from 1.16.0-rc.0 to 1.16.0 by @iOvergaard in umbraco/Umbraco-CMS#20535 * Bump vite from 7.1.9 to 7.1.11 in /src/Umbraco.Web.UI.Client by @dependabot[bot] in umbraco/Umbraco-CMS#20580 * Bump vite from 7.1.9 to 7.1.11 in /src/Umbraco.Web.UI.Login by @dependabot[bot] in umbraco/Umbraco-CMS#20621 * Bump playwright and @playwright/test in /tests/Umbraco.Tests.AcceptanceTest by @dependabot[bot] in umbraco/Umbraco-CMS#20579 * Bump the npm_and_yarn group across 2 directories with 1 update by @dependabot[bot] in umbraco/Umbraco-CMS#20863 * Dependencies: Updates some dependencies to latest minor or patch releases by @AndyButland in umbraco/Umbraco-CMS#20953 * build(deps): bumps monaco-editor from 0.54.0 to 0.55.1 by @iOvergaard in umbraco/Umbraco-CMS#21054 ### 🌈 Accessibility Improvements * Entity Actions: Create button discernible text (fixes #20205) by @OskarKruger in umbraco/Umbraco-CMS#20434 * Entity Actions: More create button discernible text, extension of #20434 by @OskarKruger in umbraco/Umbraco-CMS#20458 * Header: Adjusted button focus border color contrast by @MrHutmat in umbraco/Umbraco-CMS#20562 * Login: Added custom validation for missing password and user/email on the login form by @MrHutmat in umbraco/Umbraco-CMS#20233 * Accessibility: Adding a label attribute for `<uui-button>` in news dashboard by @MrHutmat in umbraco/Umbraco-CMS#20780 * Keyboard navigation: Return to opening element after modal close by @MrHutmat in umbraco/Umbraco-CMS#20782 ### 🚀 New Features * Preview: Allows changing the preview environment inside the preview app, and other UX changes that enhance the experience by @leekelleher in umbraco/Umbraco-CMS#20598 * Login: Adds show/hide password toggle by @MrHutmat in umbraco/Umbraco-CMS#20611 * Adds Clear Clipboard button & logic by @warrenbuckley in umbraco/Umbraco-CMS#20757 * Member types: Implement containers by @ronaldbarendse in umbraco/Umbraco-CMS#20706 * Log viewer: Improves search functionality and code quality by @iOvergaard in umbraco/Umbraco-CMS#20913 * Log Viewer: Enhances the donut chart to be responsive, link to log search, and show numbers directly by @iOvergaard in umbraco/Umbraco-CMS#20928 * Culture and Hostnames: Add ability to sort hostnames (closes #20691) by @MrHutmat in umbraco/Umbraco-CMS#20826 * Localization: Adds `termOrDefault()` method to accept a fallback value by @iOvergaard in umbraco/Umbraco-CMS#20947 * Block Grid: Sort mode by @leekelleher in umbraco/Umbraco-CMS#20869 * News Dashboard: Adding functionality to overwrite the cache duration by @NillasKA in umbraco/Umbraco-CMS#21064 * Block List: Sort mode by @leekelleher in umbraco/Umbraco-CMS#21060 * Extend RTE output in Delivery API for better support for multi-site URL resolution by @MiguelGuedelha in umbraco/Umbraco-CMS#20846 * Content Types: Introduce schema service to support future schema generation by @lauraneto in umbraco/Umbraco-CMS#21031 * Delivery API: Adding allow list for content types by @NillasKA in umbraco/Umbraco-CMS#21111 * Emails: Add `Expires` header by @rickbutterfield in umbraco/Umbraco-CMS#20285 * Indexing: Make the indexing batch size configurable by @kjac in umbraco/Umbraco-CMS#20543 * Media: Add protection to restrict access to media in recycle bin (closes #2931) by @AndyButland in umbraco/Umbraco-CMS#20378 * Collection: Introduce Collection Item Card extension type by @madsrasmussen in umbraco/Umbraco-CMS#20954 * Collection: Introduce Collection Item Ref extension type by @madsrasmussen in umbraco/Umbraco-CMS#20994 * Collection: Introduce Card and Ref Collection View kinds by @madsrasmussen in umbraco/Umbraco-CMS#21037 ### 🚤 Performance * Performance: Optimize memory footprint of document URL cache (closes #21055) by @AndyButland in umbraco/Umbraco-CMS#21066 * Distributed Background Jobs: Improve distributed background job locking behavior and performance by @nikolajlauridsen in umbraco/Umbraco-CMS#21100 * Repositories: Optimize repository caches to populate for both int and GUID keys by @AndyButland in umbraco/Umbraco-CMS#21124 * Performance: Re-introduce lazy locks by @lauraneto in umbraco/Umbraco-CMS#21102 ### 🐛 Bug Fixes ... (truncated) Commits viewable in [compare view](umbraco/Umbraco-CMS@release-17.0.2...release-17.1.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alexander Seeliger <alexsee@users.noreply.github.com>
This was referenced Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring of #21221 to resolve comments, see the original PR.
This observes Property Types and keeps a local reference to the old variable for comparinson when it changes.
When it changes the values of whos property-types have changed gets transfered.
Removing the reload and avoids value transfer as part of the Preset logic.
Also ensures the
_processIncomingDatais not only handled in the reload method of content-detail workspace, but implemented in the entity-detail reload method. (Must have been a mistake that it was not done before).